Ticket #4501 (closed Bugs: fixed)

Opened 3 years ago

Last modified 2 years ago

ARI includes/callme is in 1.2 syntax

Reported by: mbrevda Assigned to: sasargen
Priority: minor Milestone: 2.9
Component: ARI Version: 2.8-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

This seem about right, not tested all too well:

Index: includes/callme.php
===================================================================
--- includes/callme.php (revision 10209)
+++ includes/callme.php (working copy)
@@ -93,7 +93,14 @@
        $extension     = "s";
        $priority      = "1";
        $callerid      = "VMAIL/$from";
-       $variable      = "MSG=$new_path|MBOX=$from";
+       $engine_info = engine_getinfo();
+       $version = $engine_info['version'];
+       if (version_compare($version, "1.6", "ge")) {
+              $variable     = "MSG=$new_path,MBOX=$from";
+       } else {
+              $variable     = "MSG=$new_path|MBOX=$from";
+       }
+       
        /* Arguments to Originate: channel, extension, context, priority, timeout, callerid, variable, account, application, data */
        $status = $astman->Originate($channel, $extension, $context, $priority, NULL, $callerid, $variable, NULL, NULL, NULL);
        if (is_array($status))

Change History

08/15/10 11:03:16 changed by mbrevda

  • owner changed from p_lindheimer to sasargen.
  • component changed from - choose - to ARI.

09/14/10 18:54:52 changed by p_lindheimer

given that we are phasing out 1.2, I say we just change it to what works on 1.4+ (,)

09/14/10 18:56:42 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [10268]) fixes #4501 change to 1.4+ syntax (this breaks 1.2 I believe - WARNING)

09/15/10 20:14:00 changed by p_lindheimer

(In [10285]) Merged revisions 10163-10171,10173-10284 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.8

........

r10169 | p_lindheimer | 2010-07-21 11:52:03 -0700 (Wed, 21 Jul 2010) | 1 line

fixes #4461 adapt to 1.4+ asterisk syntax. This change will break 1.2 systems

........

r10226 | p_lindheimer | 2010-08-24 16:08:16 -0700 (Tue, 24 Aug 2010) | 1 line

fixes #4509 and re #4134 use proper path for call monitor

........

r10246 | mickecarlsson | 2010-09-06 22:25:50 -0700 (Mon, 06 Sep 2010) | 1 line

Re #3503 Add Chinese language as selection in FreePBX, it was removed in r7337 and I forgot to add it back when proper language files was submitted. This change should be merged to all supported version

........

r10268 | p_lindheimer | 2010-09-14 15:56:42 -0700 (Tue, 14 Sep 2010) | 1 line

fixes #4501 change to 1.4+ syntax (this breaks 1.2 I believe - WARNING)

........

01/17/11 07:55:48 changed by dani

This syntaxe change (, instead of | ) is broken with asterisk 1.4 (at least, with asterisk 1.4.36). the logs are:

[Jan 17 13:38:46] VERBOSE[9905] logger.c: -- Executing [s@vm-callme:3] BackGround?("Local/0533003186@from-internal-c316,1", "/var/spool/asterisk/voicemail/default/210/INBOX/msg0011,MBOX=210&silence/2&vm-repeat&vm-starmain") in new stack [Jan 17 13:38:46] WARNING[9905] file.c: File /var/spool/asterisk/voicemail/default/210/INBOX/msg0011,MBOX=210 does not exist in any format [Jan 17 13:38:46] WARNING[9905] file.c: Unable to open /var/spool/asterisk/voicemail/default/210/INBOX/msg0011,MBOX=210 (format 0x40 (slin)): No such file or directory [Jan 17 13:38:46] WARNING[9905] pbx.c: ast_streamfile failed on Local/0533003186@from-internal-c316,1 for /var/spool/asterisk/voicemail/default/210/INBOX/msg0011,MBOX=210&silence/2&vm-repeat&vm-starmain

replacing , with | makes it working again

02/08/11 17:25:57 changed by GameGamer43

  • status changed from closed to reopened.
  • resolution deleted.

02/08/11 17:27:47 changed by GameGamer43

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [11323]) closes #4501 - 1.4 doesnt like commas so we need to check the asterisk version first or we will end up with silence in 1.4

02/12/11 18:16:12 changed by p_lindheimer

(In [11352]) Merged revisions 11166-11264,11266-11351 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.8

........

r11323 | GameGamer?43 | 2011-02-08 14:27:47 -0800 (Tue, 08 Feb 2011) | 1 line

closes #4501 - 1.4 doesnt like commas so we need to check the asterisk version first or we will end up with silence in 1.4

........