Ticket #4519 (closed Bugs: duplicate)

Opened 1 year ago

Last modified 1 year ago

Directory 2.8.0rc1.0 Issue with Multiple choise

Reported by: troyfrew Assigned to: mbrevda
Priority: minor Milestone: 2.9
Component: Directory Version: 2.8-branch
Keywords: Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: Asterisk 1.4.x Backend Engine Version:

Description

In the directory.agi file, there is a problem where the multi choice menu breaks without a valid keycode but then pauses making the end user think the directory is not working.

here is a fix i creted for this:

74,78c74,96
<               foreach($matches as $idx => $match){
<                       $ret=$dir->getKeypress('for',$validkeys,0);if(trim($ret['result'])){break;}
<                       $ret=$dir->readContact($matches[$idx],$validkeys,0);if(trim($ret['result'])){break;}
<                       $ret=$dir->getKeypress('press',$validkeys,0);if(trim($ret['result'])){;break;}
<                       $ret=$dir->agi->say_digits($idx+1,$validkeys);if(trim($ret['result'])){$ret['result']=chr($ret['result']);break;}
---
>               while(1){
>                       foreach($matches as $idx => $match){
>                               $ret=$dir->getKeypress('for',$validkeys,0);
>                               if(trim($ret['result'])){
>                                       break;
>                               }
>                               $ret=$dir->readContact($matches[$idx],$validkeys,0);
>                               if(trim($ret['result'])){
>                                       break;
>                               }
>                               $ret=$dir->getKeypress('press',$validkeys,0);
>                               if(trim($ret['result'])){
>                                       break;
>                               }
>                               $ret=$dir->agi->say_digits($idx+1,$validkeys);
>                               if(trim($ret['result'])){
>                               $ret['result']=chr($ret['result']);
>                                       break;
>                               }
>                       }
>                       sleep(1);
>                       debug("got result: ".$ret['result']);
>                       if($ret['result']>0){break;}

Change History

09/14/10 16:30:37 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.

can you please elaborate on the issue, maybe with an example or specifics to recreate the scenario that your proposed fix addresses. I don't understand what the issue is that you are running into with your current description.

Thanks in advance.

12/07/10 07:06:56 changed by mbrevda

  • status changed from new to closed.
  • resolution set to duplicate.

Hmm, I'm going to guess this is a dup of #4591 which has been fixed. Please reopen with elaborate detail if im wrong.