Ticket #4543 (closed Feature Requests: fixed)

Opened 3 years ago

Last modified 2 years ago

set 'MODULEADMINWGET=true' in session once detecting it is necessary

Reported by: p_lindheimer Assigned to:
Priority: minor Milestone: 2.9
Component: Core - Module Admin Version: 2.8-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description (Last modified by p_lindheimer)

If we find we are timing out and falling back to wget for module admin, then we should probably at least set that condition in the session so that subsequent attempts don't keep going so slow.

We could consider setting is somewhere more permanent but maybe should just wait until 2.9 when we have a module to handle these settings and then we could update it in the database?

update: with the move to freepbx_conf, we can simply change the configuration variable. In either case, added to this we should simply re-factor the code and a function like:

file_get_contents_url()

which is effectively what we are doing, but then module_admin or any other place in the code that is going to the web to pull data can use this function where as today, it is manually done in multiple places and in thee is opportunity elsewhere to do this.

Change History

01/23/11 20:04:52 changed by p_lindheimer

  • description changed.

01/24/11 21:21:43 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [11104]) closes #4543 creates file_get_contents_url() with built in failover to wget

01/24/11 21:28:04 changed by p_lindheimer

(In [11105]) use file_get_contents_url() re #4543