Ticket #4582 (closed Feature Requests: fixed)

Opened 3 years ago

Last modified 3 years ago

add ability to attempt reconnects to manager if unexpected EOF detected

Reported by: p_lindheimer Assigned to:
Priority: minor Milestone: 2.9
Component: FreePBX Framework Version: SVN-HEAD
Keywords: php-asmanager.php Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

On some very busy systems there have been incidents of Asterisk dropping the manager connection. Most of the FreePBX code does not do a good job of checking for valid responses (such as with database_get() commands and similar) through the manager. This feature is to try a low level reconnect of an unexpected closed connection and retry the command that was interrupted.

This is not a good substitute for dealing with such failures as the root cause should be determined and fixed, but it's still not bad to try and reconnect and avoid such issues.

Change History

10/08/10 18:03:29 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [10383]) closes #4582 adds reconnect attempts as well as some additional logging with logging levels - needs more testing, particularly on known failing systems, should also be applied against the agi version of php-asmanager.php

11/04/10 12:25:57 changed by p_lindheimer

(In [10530]) missing optional events paramter re #4582

11/10/10 00:45:31 changed by mbrevda

(In [10543]) Merged revisions 10370,10375-10384,10400-10401,10412-10413,10416,10442,10449,10528,10530,10537-10539,10542 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/trunk

................

r10370 | mbrevda | 2010-10-06 09:47:59 +0200 (Wed, 06 Oct 2010) | 1 line

re #4566 - new framework functions

................

r10375 | p_lindheimer | 2010-10-08 02:08:25 +0200 (Fri, 08 Oct 2010) | 1 line

adds default value for DIVERSIONHEADER re #4580

................

r10376 | mickecarlsson | 2010-10-08 20:02:11 +0200 (Fri, 08 Oct 2010) | 1 line

Fixed spelling errors in comments

................

r10377 | mickecarlsson | 2010-10-08 20:07:12 +0200 (Fri, 08 Oct 2010) | 1 line

Fixed spelling errors in config.php

................

r10378 | mickecarlsson | 2010-10-08 20:11:40 +0200 (Fri, 08 Oct 2010) | 1 line

Fixed spelling errors in page.modules.php

................

r10379 | mickecarlsson | 2010-10-08 20:18:42 +0200 (Fri, 08 Oct 2010) | 1 line

Fixed spelling errors in freepbx.php

................

r10380 | p_lindheimer | 2010-10-08 20:30:23 +0200 (Fri, 08 Oct 2010) | 1 line

turn off events with astman, not being used, and use cache mode for generate_hints

................

r10381 | p_lindheimer | 2010-10-08 22:29:22 +0200 (Fri, 08 Oct 2010) | 1 line

oops just set events off when first connecting

................

r10382 | p_lindheimer | 2010-10-08 23:53:46 +0200 (Fri, 08 Oct 2010) | 1 line

check if array to avoid warnings

................

r10383 | p_lindheimer | 2010-10-09 00:03:29 +0200 (Sat, 09 Oct 2010) | 1 line

closes #4582 adds reconnect attempts as well as some additional logging with logging levels - needs more testing, particularly on known failing systems, should also be applied against the agi version of php-asmanager.php

................

r10384 | p_lindheimer | 2010-10-09 22:05:31 +0200 (Sat, 09 Oct 2010) | 1 line

fixes #4583 undefined var

................

r10400 | p_lindheimer | 2010-10-15 19:04:25 +0200 (Fri, 15 Oct 2010) | 1 line

more explicit log messages on failures

................

r10401 | p_lindheimer | 2010-10-15 20:00:50 +0200 (Fri, 15 Oct 2010) | 1 line

r10383, r10384, 10400 from ~/common/php-asmanager.php

................

r10412 | mickecarlsson | 2010-10-22 20:20:46 +0200 (Fri, 22 Oct 2010) | 1 line

Close #4536, remove / from MOHDIR variable

................

r10413 | mickecarlsson | 2010-10-22 20:23:47 +0200 (Fri, 22 Oct 2010) | 1 line

More help text for MOHDIR in amportal.conf

................

r10416 | p_lindheimer | 2010-10-22 22:21:41 +0200 (Fri, 22 Oct 2010) | 24 lines

Merged revisions 10285-10415 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.8

................

r10387 | GameGamer?43 | 2010-10-11 16:07:25 -0700 (Mon, 11 Oct 2010) | 1 line

closes #4585 - fixes logic issue with getInstallableModules

................

r10388 | p_lindheimer | 2010-10-12 09:12:05 -0700 (Tue, 12 Oct 2010) | 1 line

fixes #4587 redeclaration of parse_DialRulesFile(), 2.8 tarball needs to be roled for this to take affect

................

r10389 | p_lindheimer | 2010-10-12 09:14:08 -0700 (Tue, 12 Oct 2010) | 1 line

re #4587 syntax error in checked in fix

................

r10415 | p_lindheimer | 2010-10-22 13:09:58 -0700 (Fri, 22 Oct 2010) | 7 lines ................

r10414 | p_lindheimer | 2010-10-22 13:01:04 -0700 (Fri, 22 Oct 2010) | 1 line

fixes #4602 don't die() just report the error

................

................

................

r10442 | mickecarlsson | 2010-10-24 12:02:47 +0200 (Sun, 24 Oct 2010) | 1 line

Re #4527 - fixed correct path for .js file page.module.php

................

r10449 | mickecarlsson | 2010-10-28 19:21:42 +0200 (Thu, 28 Oct 2010) | 1 line

Removed svn:executable from .dif files in recordings

................

r10528 | mbrevda | 2010-11-03 12:23:47 +0200 (Wed, 03 Nov 2010) | 1 line

downstream alignments

................

r10530 | p_lindheimer | 2010-11-04 18:25:56 +0200 (Thu, 04 Nov 2010) | 1 line

missing optional events paramter re #4582

................

r10537 | mickecarlsson | 2010-11-09 18:02:25 +0200 (Tue, 09 Nov 2010) | 1 line

Make sure that we set a cookie on the first page load. Weird things happen with textdomain if this is not set

................

r10538 | mickecarlsson | 2010-11-09 18:05:37 +0200 (Tue, 09 Nov 2010) | 1 line

Fix typo in previous ci

................

r10539 | mickecarlsson | 2010-11-09 18:29:35 +0200 (Tue, 09 Nov 2010) | 1 line

More typos in previous ci

................

r10542 | mbrevda | 2010-11-10 07:07:33 +0200 (Wed, 10 Nov 2010) | 1 line

no need for the entire indication, set +x on setup_svn

................