Ticket #4688 (closed Bugs: wontfix)

Opened 2 years ago

Last modified 2 years ago

Third-Party Extension Config Module doesn't get MySQL usernames/passwords from amportal.conf

Reported by: sir_sip Assigned to:
Priority: minor Milestone: 2.9
Component: Third Party Module Version: 2.8-branch
Keywords: Cc:
Confirmation: Need Feedback Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

I realize that the Extension Config module, located at http://www.freepbx.org/trac/browser/contributed_modules/release (extcfg-0.1.tgz) is three years old, but it's still a handy tool for checking and changing the status of call waiting and call forwarding for extensions, if some of your users can't figure out how to do it themselves. And when one of the features isn't working, it's easy to figure out if it's a problem with Asterisk or the user's phone/device. The only problem is that it uses the default usernames and passwords for the MySQL database instead of parsing them out of /etc/amportal.conf. If your system doesn't use the defaults, which is a trait of Elastix and possibly other distributions, then you have to manually go into that file and change them. It would be great if it could read amportal.conf and pick up those values.

I might also suggest that this little tool is useful enough that it really should be part of your "official" third party repository, or since it appears that p_lindheimer wrote it, maybe even part of the main distribution.

Change History

12/14/10 19:37:28 changed by sir_sip

Oops, I meant you have to go into the module's functions.inc.php, not amportal.conf!

12/14/10 19:41:10 changed by tm1000

  • confirmation changed from Unreviewed to Need Feedback.

We don't need to read the amportal.confg file.

All database functions can be used through $db (pear DB)

Does this run inside of FreePBX or outside of FreePBX? It;s a module so I will assume inside and therefore it should not be parsing the amportal.conf file.

Especially considering the fact that this file will be going away in the near future.

(follow-up: ↓ 4 ) 12/14/10 21:38:22 changed by p_lindheimer

I've never used that module but just glanced at the source code…

My suggestion would be to open a feature request to have CF, CFB, CFU, and DND added to the extensions/users page, which could either be done with another module (like that one modified) simply hooking in and adding those fields, or possibly added to core.

Having a separate module to present a few random settings for an extension doesn't make much sense.

btw - the module is not in the Extended Repository because as you have pointed out, it is not under regular maintenance which is one of a few criteria that is needed for modules to be there.

(in reply to: ↑ 3 ) 12/14/10 22:26:56 changed by sir_sip

I will make the feature request, but keep in mind that those settings can also be changed with feature codes, provider the phone or adapter doesn't intercept the codes for some other purpose (Linksys products are REALLY bad about that by default). So you don't necessarily want to save the settings unless you've actually changed one, because the user might be trying to change it while you have the page open.

The features you can check or change are DND, Call Waiting, Call Forward All, Call Forward Busy, and Call Forward No Answer. Call Waiting was the one I had to check tonight.

12/14/10 22:41:33 changed by p_lindheimer

you are right, it is probably best just left in the ARI for changing there since a screen left open with stale data can result in updating a setting that has been set by the user (unless you jump through a few hoops to check for changes…). Call Waiting is already on the extension page, I would say just leave it.

If someone wants, they can modify this module to just hook into the extension page which would really be a better place for it if one is going to use them.

Otherwise, just tell the user to set their own settings :-)

12/14/10 22:43:03 changed by tm1000

  • status changed from new to closed.
  • resolution set to wontfix.

Closed.

See ticket #4690

02/05/11 18:01:45 changed by pnlarsson

(In [11299]) Added instead of hardcoded settings. Added some images, re #4688