Ticket #4697 (closed Feature Requests: fixed)

Opened 1 year ago

Last modified 1 year ago

SetMusicOnHold application is deprecated

Reported by: mickecarlsson Assigned to:
Priority: minor Milestone: 2.9
Component: Music On Hold Version: 2.8-branch
Keywords: Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: Asterisk 1.6 Backend Engine Version:

Description

As in title, SetMusicOnHold? application is deprecated as of Asterisk 1.6.

The new Set(CHANNEL(musicclass)=...) is to be used.

We need to update extensions.class to reflect this. Ticket is a reminder to do so

Change History

12/17/10 14:08:49 changed by mickecarlsson

This is from my Asterisk 1.4.37 (only relevant parts shown):

CLI> core show function CHANNEL

  -= Info about function 'CHANNEL' =-

[Syntax]
CHANNEL(item)

[Synopsis]
Gets/sets various pieces of information about the channel.

[Description]
Gets/set various pieces of information about the channel.
Standard items (provided by all channel technologies) are:
R/W     musicclass         class (from musiconhold.conf) for hold music

It seems that this was introduced in 1.4, and as we only support 1.4 and up I would say that we can change the syntax without breaking installations. Testing is of course vital.

12/18/10 13:39:48 changed by p_lindheimer

(In [10711]) - adds logic so FORCE_CONFRIM calls will force any outbound call to user confirmation

in this mode there is some reduced functionality. There is no detection for a call answered by someone else. As always the first will win, others will get dead air instead of a friendly (you got beat) message. (Same if they hangup). Modifying to not get dead air will probably come when we switch form DB variables to SHARED() where channels can share variables and we don't have the cleanup issues of DB(), re #4701

- fixes a couple of instances of deprecated SetMusicOnHold? re #4697 - fixes an instance of deprecated DbDel? - untested fixes #4702 macro-dialout-enum missing logic

12/18/10 14:19:12 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [10713]) closes #4697 use CHANNEL(musicclass) for 1.4+

12/18/10 14:35:51 changed by p_lindheimer

(In [10714]) closes #4697 use CHANNEL(musicclass) instead of SetMusicClass?