DISA allow hangup feature doesn't seem to work

logs

Looks like it *might* be an Asterisk bug or pseudo related. We may have encountered similar in the fax module in the past. (e.g. this may not be 1.8 only, and may be our mis-use of calling a destination that is housed in a variable).

The offending line is:

exten => _[0-9a-zA-Z*#].,n,Goto(${DISA})

where DISA was already set, example might be:

exten => 12,1,Set(_DISA="disa,12,newcall")

and results in a confused interpreter:

[Feb 23 01:16:47] VERBOSE[7685] pbx.c: -- Executing [488@disa-dial:4] Goto("IAX2/2080-13979", ""disa,12,newcall"") in new stack
------>>> [Feb 23 01:16:47] NOTICE[7685] pbx.c: Cannot find extension context '"disa'
[Feb 23 01:16:47] WARNING[7685] pbx.c: Priority 'newcall"' must be a number > 0, or valid label

I think the extra quotes mean it is all being consumed as a single entity.

That may be because we have the DISA target in quotes (") when we set it. One thing you could try is if the following works, try modifying extensions_additional.conf:

exten => 5,1,Set(_DISA=disa\,12\,newcall)

where you backslash the ',' but take out the outer quotes (") and see if that fixes it. If not, we may have to resort to something similar we do with faxing where we replace the ',' with '^{' in the assignment and then use CUT to create it:}

Set it:

exten => s,n,Set(FAX_DEST=ext-fax^222^1)

then:

exten => fax,1,Goto(${CUT(FAX_DEST,^,1)},${CUT(FAX_DEST,^,2)},${CUT(FAX_DEST,^,3)})

Please try removing the quotes (") and adding the back-slash (\) to see if that fixes it and report back, otherwise we will go the more drastic route.

ok did some testing and it's coming back to me now.

The 'double quotes' works with 1.4 (at least in some modes). You can back-slash the commas (,) in 1.4 and it accepts it but then you get the same error as in 1.8. In 1.8, if you back-slash the commas you get an error, but if you leave them, then it is happy because 'Set()' no longer has arguments and further, the goto works.

So … as I recall, this all stems from about 3 different interpretations that the Asterisk team did when interpreting and setting variables for uses like this and is a real mess. The one solution that works across the board is what we did for faxing, so … that's the fix we'll need to put in. In the meantime, on your 1.8 system, if you get rid of the double quotes you are probably good to go until we get the real fix done (which may be as early as today…)

(In [11570]) fixes #4859 decompose goto destination to deal with inconsistent Asterisk behavior between versions

(In [11571]) Merged revisions 11496,11570 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.9

........

r11496 | p_lindheimer | 2011-02-19 20:24:18 -0800 (Sat, 19 Feb 2011) | 1 line

fixes #4783 if no authenticate used (which answers the channel) then put in an answer()

........

r11570 | p_lindheimer | 2011-02-23 12:22:32 -0800 (Wed, 23 Feb 2011) | 1 line

fixes #4859 decompose goto destination to deal with inconsistent Asterisk behavior between versions

........