Ticket #4970 (closed Bugs: fixed)

Opened 2 years ago

Last modified 2 years ago

redirect should enable buffering before clearing it

Reported by: mbrevda Assigned to:
Priority: minor Milestone: 2.9
Component: FreePBX Framework Version: 2.9-branch
Keywords: Cc:
Confirmation: Need testing Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

In views.functions.php, line 203 we call ob_end_clean(). If there is no buffer, we get an error as follows: 

2011-Mar-15 10:25:10	/home/svn.freepbx.org/freepbx/branches/2.9/amp_conf/htdocs/admin/libraries/view.functions.php:203
[NOTICE]: ob_end_clean() [<a href='ref.outcontrol'>ref.outcontrol</a>]: failed to delete buffer. No buffer to delete.

We should probably call ob_start (or similar) before trying to clear the buffer to ensure that a buffer exists.

Change History

03/15/11 11:43:03 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need testing.

I believe that will generate a similar warning if a buffer already exists?

In the scenario where you run into that, can you try calling:

ob_get_status()

and see what is being returned from that call. One would think that the results of that should tell us if there is an output buffer or not so we can decide if we need to call ob_end_clean().

03/15/11 11:57:51 changed by mbrevda

  • status changed from new to closed.
  • resolution set to fixed.

(In [11818]) closes #4970 - dont end buffereing if its was never started

03/17/11 13:59:12 changed by p_lindheimer

(In [11825]) fixes #4970 MIXMON_POST is being migrated in core's install script but the generation was still trying to pull the value from the old globals table location

03/17/11 14:00:20 changed by p_lindheimer

oops should have been #4970 for the above ticket close

03/17/11 14:00:55 changed by p_lindheimer

I mean #4979 - can't type today