Ticket #5097 (closed Bugs: fixed)

Opened 2 years ago

Last modified 2 years ago

If permit and/or deny fields in Asterisk API are empty, Asterisk fails to start

Reported by: mickecarlsson Assigned to:
Priority: minor Milestone: 2.9
Component: Asterisk API Version: 2.9-branch
Keywords: Cc:
Confirmation: Need Feedback Distro:
Backend Engine: Asterisk 1.8 Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Go to Asterisk API, create a manager, but don't enter anything in permit or deny, save, then click on Apply Changes. Asterisk reloads but exits as soon as it is loading manager_additional.conf. 

[Apr 24 06:56:29] VERBOSE[5723] config.c:   == Parsing '/etc/asterisk/manager_additional.conf': [Apr 24 06:56:29] VERBOSE[5723] config.c:   == Found
[Apr 24 06:56:29] VERBOSE[5723] config.c:   == Parsing '/etc/asterisk/manager_custom.conf': [Apr 24 06:56:29] VERBOSE[5723] config.c:   == Found
[Apr 24 06:56:29] WARNING[5723] acl.c: Invalid IP address:

I have only tested this against Asterisk 1.8

Change History

04/24/11 09:57:26 changed by mickecarlsson

  • milestone changed from 2.10 to 2.9.

04/24/11 16:02:44 changed by mickecarlsson

  • summary changed from If permit and/or deny fields in Asterisk API is empty, Asterisk fails to start to If permit and/or deny fields in Asterisk API are empty, Asterisk fails to start.

04/25/11 16:26:30 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.

so to clarify, is the issue that we are spiting out an empty permit and/or deny line, e.g.

permit=

or

deny=

and that is what is breaking Asterisk?

04/26/11 00:57:46 changed by mickecarlsson

Hmm, I have not tested to have these removed. (later)If I remove permit= and deny= Asterisk start OK. But IMHO that is not an option security wise. If we populate it with permit=127.0.0.1/255.255.255.0 and deny=0.0.0.0/0.0.0.0 and let users change that to their values.

While we are at it, if I only select cdr for read, there is an empty line write=, that is probably not OK and needs to be fixed

04/26/11 20:33:32 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [12050]) fixes #5097 broken js stopped validation of IP