Comments starting with '#' are deprecated in php 5.3

that is a result of this line in the sip.conf file:

#include sip_general_additional.conf

well sipsettings is parsing the files in sipsettings_check_custom_files() with:

$sip_conf = @parse_ini_file($file,true);

where we are checking if there are any settings in the custom or other files so we can warn them of potential conflicts. The same thing will exist in IAX Settings I think. We are already suppressing the warning with the "@" notation.

If we are concerned about the warning (which is always valid), we could use file() and then dump all the lines that have a #include, then implode what remains into parse_ini_string() instead?

Thoughts?

(We apparently ARENT suppressing the error.) If the function will fail in the future then we should find a new way to parse the file. The parse_ini_file() seems to no longer be designed to handel our needs. Hence, we should probably write our own.

'@' suppresses the error to the screen, I think notices are always sent if you have an error handler.

In any event, I agree it could mean problems in the future. In this case and IAX Settings there is simply a need to parse the ini while ignoring the #includes (since we don't care about what is in the auto-generated ones). So we can add a utility that does this and used by both these modules, affectively doing what I described above which is stripping out the #includes and then parsing what is left.

I agree that a more flexible method for us will be to write our own method to handle parsing files.

given the current usage of this, closing as wontfix for now and if it makes PHP fail going forward or becomes a real issue we can address the problem down the road.