Ticket #5566 (closed Bugs: fixed)

Opened 1 year ago

Last modified 1 year ago

Add Admin shows Backup and Restore Multiple Times

Reported by: mobiusworks Assigned to: mbrevda
Priority: minor Milestone: 2.11
Component: Backup & Restore Version: 2.10-branch
Keywords: administrators core Cc:
Confirmation: Pending Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Just installed the Beta of the new Distro featuring 2.10 RC1, when going to add administrator the list shows "Backup and Restore" 4 times in the list.

Change History

02/29/12 21:13:34 changed by mobiusworks

  • version deleted.
  • milestone set to 2.10.

03/01/12 14:16:06 changed by p_lindheimer

  • confirmation changed from Unreviewed to Pending.
  • component changed from System Admin to Backup & Restore.
  • owner changed from tonyclewis to mbrevda.
  • version set to 2.10-branch.
  • milestone changed from 2.10 to 2.11.
  • keywords set to administrators core.

Moshe,

the Administrators page results in 4 "Backup & Restore" choices as a result of the 4 menuitems that are all called the same: 

  <menuitems>
    <backup needsenginedb="yes">Backup &amp; Restore</backup>
    <backup_servers needsenginedb="yes" hidden="true">Backup &amp; Restore</backup_servers>
    <backup_templates needsenginedb="yes" hidden="true">Backup &amp; Restore</backup_templates>
    <backup_restore needsenginedb="yes" hidden="true">Backup &amp; Restore</backup_restore>
  </menuitems>

Ping me on this so we can discuss and help me understand if this is needed and why so we can address it where ever appropriate. RIght now it ends up in just a single menu choice in the nav bar since they are all called the same.

03/01/12 16:41:54 changed by mbrevda

Actually, it ends up as a single name because the other three are hidden. The issue how ampusers sees modules vs. controllers (aka page.foo.php). It is probably do desired to leave the ability for controllers to be shown individually, it should be a bit more specific about with page its referencing though. I.e. Backup & Restore (backup_templates), etc.

03/01/12 18:26:00 changed by p_lindheimer

what's not clear … do you need those entries? Ping me on this offline if need be. If they need to be there then I can fix the Administrator module to deal with the duplicates or ignore hidden ones, just not clear why the other entries needed to be in the xml file?

03/02/12 18:19:27 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [13765]) fixes #5566 make hidden names unique and enable partial access to backup module components for Administrators

03/06/12 18:02:08 changed by p_lindheimer

(In [13776]) Merged revisions 13727,13729-13730,13733,13735-13737,13739,13741,13743,13745-13746,13748-13749,13751,13760,13762,13765,13767-13770,13772-13773 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.10

........

r13727 | p_lindheimer | 2012-02-29 11:15:07 -0800 (Wed, 29 Feb 2012) | 1 line

[Auto Checking in outstanding changes in endpointman]

........

r13729 | p_lindheimer | 2012-02-29 11:15:23 -0800 (Wed, 29 Feb 2012) | 1 line

[Module package script: endpointman 2.10.3.6]

........

r13730 | p_lindheimer | 2012-03-01 11:45:14 -0800 (Thu, 01 Mar 2012) | 1 line

fixes #5574 handle single digits in DISA

........

r13733 | p_lindheimer | 2012-03-01 11:48:49 -0800 (Thu, 01 Mar 2012) | 1 line

[Auto Checking in outstanding changes in disa]

........

r13735 | p_lindheimer | 2012-03-01 11:49:00 -0800 (Thu, 01 Mar 2012) | 1 line

[Module package script: disa 2.10.0.2]

........

r13736 | p_lindheimer | 2012-03-01 13:29:29 -0800 (Thu, 01 Mar 2012) | 1 line

fixes #5568 tooltip incorrect

........

r13737 | p_lindheimer | 2012-03-01 14:15:33 -0800 (Thu, 01 Mar 2012) | 1 line

fixes #5385 don't replace FROM_DID with s if set properly

........

r13739 | p_lindheimer | 2012-03-01 14:40:48 -0800 (Thu, 01 Mar 2012) | 1 line

fixes #5381 0 reverts to default timeout so set to very small when 0 is chosen

........

r13741 | p_lindheimer | 2012-03-01 16:56:41 -0800 (Thu, 01 Mar 2012) | 1 line

fixes #5639 voicemail module should not change the context, the core_device_add will put in the proper nnn@device if not set since the proper contexts are sym linked to the device directories

........

r13743 | p_lindheimer | 2012-03-01 17:20:26 -0800 (Thu, 01 Mar 2012) | 1 line

[Auto Checking in outstanding changes in core]

........

r13745 | p_lindheimer | 2012-03-01 17:20:39 -0800 (Thu, 01 Mar 2012) | 1 line

[Module package script: core 2.10.0.1]

........

r13746 | p_lindheimer | 2012-03-01 17:20:42 -0800 (Thu, 01 Mar 2012) | 1 line

[Auto Checking in outstanding changes in ivr]

........

r13748 | p_lindheimer | 2012-03-01 17:20:53 -0800 (Thu, 01 Mar 2012) | 1 line

[Module package script: ivr 2.10.0.6]

........

r13749 | p_lindheimer | 2012-03-01 17:20:56 -0800 (Thu, 01 Mar 2012) | 1 line

[Auto Checking in outstanding changes in voicemail]

........

r13751 | p_lindheimer | 2012-03-01 17:21:07 -0800 (Thu, 01 Mar 2012) | 1 line

[Module package script: voicemail 2.10.0.3]

........

r13760 | p_lindheimer | 2012-03-02 08:12:06 -0800 (Fri, 02 Mar 2012) | 1 line

fixes #5638 and brings epm in sync with other changes on gitbub

........

r13762 | p_lindheimer | 2012-03-02 08:13:28 -0800 (Fri, 02 Mar 2012) | 1 line

[Module package script: endpointman 2.10.3.7]

........

r13765 | p_lindheimer | 2012-03-02 15:19:27 -0800 (Fri, 02 Mar 2012) | 1 line

fixes #5566 make hidden names unique and enable partial access to backup module components for Administrators

........

r13767 | p_lindheimer | 2012-03-02 15:20:25 -0800 (Fri, 02 Mar 2012) | 1 line

[Module package script: backup 2.10.0.20]

........

r13768 | GameGamer?43 | 2012-03-02 16:28:17 -0800 (Fri, 02 Mar 2012) | 1 line

closes #5649 - add support for device settings not previously in bulkextensions, campon, new recording code, and qnostate

........

r13769 | GameGamer?43 | 2012-03-05 11:44:48 -0800 (Mon, 05 Mar 2012) | 1 line

closes #5652 - fix logic error causing extensions to go missing

........

r13770 | p_lindheimer | 2012-03-05 12:38:34 -0800 (Mon, 05 Mar 2012) | 1 line

[Auto Checking in outstanding changes in ringgroups]

........

r13772 | p_lindheimer | 2012-03-05 12:38:54 -0800 (Mon, 05 Mar 2012) | 1 line

[Module package script: ringgroups 2.10.0.4]

........

r13773 | p_lindheimer | 2012-03-06 14:04:13 -0800 (Tue, 06 Mar 2012) | 1 line

fixes #5654 PHP 5.4 incompatabilities shadowing superglobals in functions variable names

........