Ticket #5695 (closed Bugs: fixed)

Opened 1 year ago

Last modified 1 year ago

Minor error in code for menu causing malformed html.

Reported by: TSM Assigned to:
Priority: minor Milestone: 2.11
Component: FreePBX Framework Version: 2.10-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

views/menu.php @ 120 

. (isset($classes) && count($classes)?' class="' . implode(' ', $classes) . '"':'').'>'

This will correct error with no space between class tag and previous target/href tag. Also it will not include tag reference is there is nothing to do.

Change History

03/20/12 19:43:38 changed by p_lindheimer

please provide a diff file in the future, "line 120" is not always line 120 when things change and it can be difficult to see exactly where a suggestion is suppose to go without a diff. thanks and thanks for the fix.

03/21/12 19:37:52 changed by p_lindheimer

  • owner changed.
  • component changed from Web interface to FreePBX Framework.

03/21/12 19:38:39 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [13863]) fixes #5695 mal formed html when no classes

03/26/12 17:26:17 changed by p_lindheimer

(In [13915]) Merged revisions 13790,13801,13805,13840,13842,13844,13863,13869-13870,13876,13907,13909,13913-13914 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.10

........

r13790 | p_lindheimer | 2012-03-08 08:56:52 -0800 (Thu, 08 Mar 2012) | 1 line

closes #5662 adds mixmonitor and stopmixmonitor methods, not tested but not used anywhere yet

........

r13801 | p_lindheimer | 2012-03-13 08:31:18 -0700 (Tue, 13 Mar 2012) | 1 line

add logging when AMI connection can't be made

........

r13805 | p_lindheimer | 2012-03-14 11:33:02 -0700 (Wed, 14 Mar 2012) | 1 line

provide option to leave mailbox= lines as some devices subscribe whether or not they have mailboxes leading to many notices in the logs re #5678

........

r13840 | mbrevda | 2012-03-15 04:27:01 -0700 (Thu, 15 Mar 2012) | 1 line

comments

........

r13842 | mbrevda | 2012-03-15 05:34:51 -0700 (Thu, 15 Mar 2012) | 1 line

closes #5647 - allow blank id to be a 'unique' destiantion identifier

........

r13844 | mbrevda | 2012-03-15 06:43:15 -0700 (Thu, 15 Mar 2012) | 1 line

re #5647

........

r13863 | p_lindheimer | 2012-03-21 16:38:39 -0700 (Wed, 21 Mar 2012) | 1 line

fixes #5695 mal formed html when no classes

........

r13869 | mbrevda | 2012-03-23 02:47:08 -0700 (Fri, 23 Mar 2012) | 1 line

closes #5708, pusblishing optional, as many more framework goodies coming next week

........

r13870 | p_lindheimer | 2012-03-23 10:47:34 -0700 (Fri, 23 Mar 2012) | 1 line

fixes RCE security vulnerability reported and solution provided by Martin Tschirsich with some bug fixes present in his original patch

........

r13876 | p_lindheimer | 2012-03-23 11:40:54 -0700 (Fri, 23 Mar 2012) | 1 line

fix potential XSS security issue

........

r13907 | mbrevda | 2012-03-26 10:01:06 -0700 (Mon, 26 Mar 2012) | 1 line

make menubar less jumpy and more stable/polished; menu bottons shouldnt hide anymore

........

r13909 | mbrevda | 2012-03-26 10:18:48 -0700 (Mon, 26 Mar 2012) | 1 line

add try exec ext and some includes for posible future features

........

r13913 | mbrevda | 2012-03-26 11:25:34 -0700 (Mon, 26 Mar 2012) | 1 line

revert r13909

........

r13914 | GameGamer?43 | 2012-03-26 11:36:51 -0700 (Mon, 26 Mar 2012) | 1 line

Adds tryexec application

........