Ticket #5696 (closed Bugs: wontfix)

Opened 1 year ago

Last modified 1 year ago

Hide menu bar via CSS until JS ready event makes it visible

Reported by: TSM Assigned to: mbrevda
Priority: minor Milestone: 2.11
Component: Web interface Version: 2.10-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

admin/assets/css/mainstyle.css @ 361 

.menubar { padding-left: 3px; display: none;}/*spacing beteen firsl/last button and toolbar edge*/

This will set the menu bar to be hidden till the ready event is fired off and forms the menu correctly and makes it visible.

Change History

03/20/12 19:54:06 changed by p_lindheimer

  • owner set to mbrevda.

please provide a diff if possible.

(follow-up: ↓ 3 ) 03/21/12 01:34:04 changed by mbrevda

Why?

(in reply to: ↑ 2 ) 03/22/12 10:56:00 changed by TSM

Replying to mbrevda:

Why?

if the css tag is set to 'display:none' then you do not see the bar at the top until it is fully rendered. In you JS you have a $('menubar').show().menu(); which activates it correctly.

03/22/12 11:03:32 changed by mbrevda

I know what it does - I'm struggling to understand WHY you want to do that? Is there some benefit to the user if the menu bar i"jumps" in to place once its fully generated? Is this safe considering jQuery weakness in positioning hidden elements?

03/22/12 11:28:09 changed by mbrevda

  • status changed from new to closed.
  • resolution set to wontfix.
5:09 PM <mbrevda> what is the goal?
5:10 PM <TSM2> mbrevda: ahh that just makes the page loading a bit nicer, because the menu is only rendered once the entire page is loaded if display != none then the menu at the top shows up all unformatted till the JS is fired off
5:10 PM <TSM2> so menu is hidden till JS correctly renders the menu
5:14 PM <mbrevda> TSM2: I had that at one point - it looked terrible to have a blank at the top of the page, and then have it jumping in when it was ready
5:15 PM <mbrevda> TSM2: part of the issue us that the menu library is so crapy it didnt even make it in to jquery as alpha
5:15 PM <mbrevda> however, it was the best at the time
5:15 PM <mbrevda> so, hopefully for 2.11 (ha!) we will look in to fixing that
5:16 PM <mbrevda> (together with all the other bugs it has)
5:20 PM <mbrevda> TSM2: ?
5:21 PM <TSM2> i dont find it jumps on my page, it shows up fairly well
5:23 PM <TSM2> jquery UI have a menu in development, hopfully soon it will make it
5:23 PM <TSM2> http://wiki.jqueryui.com/w/page/12137997/Menu
5:23 PM <TSM2> which is basicly this http://www.filamentgroup.com/lab/jquery_ipod_style_and_flyout_menus/
5:23 PM <mbrevda> yup - that is the plan. I would close the ticket for now, we can wait for that and hopefull include it when its ready
New messages
5:25 PM <TSM2> ok if you think thats best, thought the small CSS change would be so minor it may just make it look a little cleaner on load
5:27 PM <mbrevda> TSM2: Ive tried it - its not the way to go :(