Ticket #5728 (new Bugs)

Opened 1 year ago

Last modified 1 year ago

Recording module use native php commands and usergroup from amp_cfg.

Reported by: TSM Assigned to:
Priority: minor Milestone: 2.11
Component: Core - Module Admin Version: 2.10-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Recording module should use PHP commands for chgrp/chmod where possible for portability and safety. Also use usergroup specified in $amp_cfg. 

--- page.recordings.php.original        2012-03-27 14:45:13.000000000 +0100
+++ page.recordings.php 2012-03-27 14:47:46.000000000 +0100
@@ -210,8 +210,8 @@
                $suffix = preg_replace('/[^0-9a-zA-Z]/','',substr(strrchr($_FILES['ivrfile']['name'], "."), 1));
                $destfilename = $recordings_save_path.$dest."ivrrecording.".$suffix;
                move_uploaded_file($_FILES['ivrfile']['tmp_name'], $destfilename);
-               system("chgrp asterisk ".$destfilename);
-               system("chmod g+rw ".$destfilename);
+               chgrp($destfilename,$amp_conf['AMPASTERISKWEBGROUP']);
+               chmod($destfilename,"g+rw");
                echo "<h6>"._("Successfully uploaded")." ".$_FILES['ivrfile']['name']."</h6>";
                $rname = rtrim(basename($_FILES['ivrfile']['name'], $suffix), '.');
        } ?>

Change History

03/27/12 10:03:29 changed by TSM

update 

--- page.recordings.php.original        2012-03-27 14:45:13.000000000 +0100
+++ page.recordings.php 2012-03-27 14:47:46.000000000 +0100
@@ -210,8 +210,8 @@
                $suffix = preg_replace('/[^0-9a-zA-Z]/','',substr(strrchr($_FILES['ivrfile']['name'], "."), 1));
                $destfilename = $recordings_save_path.$dest."ivrrecording.".$suffix;
                move_uploaded_file($_FILES['ivrfile']['tmp_name'], $destfilename);
-               system("chgrp asterisk ".$destfilename);
-               system("chmod g+rw ".$destfilename);
+               chgrp($destfilename,$amp_conf['AMPASTERISKGROUP']);
+               chmod($destfilename,"g+rw");
                echo "<h6>"._("Successfully uploaded")." ".$_FILES['ivrfile']['name']."</h6>";
                $rname = rtrim(basename($_FILES['ivrfile']['name'], $suffix), '.');
        } ?>