Ticket #874 (closed Bugs: fixed)

Opened 7 years ago

Last modified 6 years ago

Allow wait for tone in dialing rules

Reported by: etolnay Assigned to: wozto1s
Priority: minor Milestone: 2.2
Component: Core Version:
Keywords: Cc:
Confirmation: Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Although this is not frequent, we were required to build an asterisk box behind the current PBX box, capable of making calls outside and to other non-asterisk internals. This only worked by allowing the letter W (for waiting for dialtone after requesting an external line) to the isDialpatternChar javascript function in common/script.js.php.

Change History

05/25/06 00:21:49 changed by p_lindheimer

  • owner changed.
  • type changed from Patches to Bugs.
  • component changed from - choose - to Core.

so you are saying isDialpatternChar() is not allowing w and it should? (which I agree with). I would call this a bug since w is a valid dial character (such as in this case you mention).

05/25/06 03:55:23 changed by wozto1s

Wouldn't you put the 'W' in the Outbound Prefix ?

05/25/06 14:41:03 changed by p_lindheimer

yeah - but are there scenarios where you might want to put it elsewhere? It may be too restrictive, I know I have caught a lot of things that I think are too restrictive. Not that this is the place to discuss it - but should we have a global setting that turns off all javascript checks like that with a standard way for modules and core to subscribe to the flag that is set somewhere?

05/27/06 07:51:03 changed by wozto1s

  • owner set to wozto1s.
  • status changed from new to assigned.
  • milestone set to 2.2.

Turning JavaScript? off is not currently an option. Before I did the form validation functions, virtually every page was using JavaScript? to submit the page. I changed this as that just plain silly!

The form validation is now what ensures the correct 'required' fields are set for the database, therefore turning it off would cause un told database query errors.

Had I not made the changes around form validation, then if a user had JavaScript? turned off then the form just wouldn't submit.

The answer here is to create another validation function specific to the dial rules which will allow 'w' in the dial rules, which I'l do for v2.2

06/03/06 20:16:23 changed by wozto1s

  • status changed from assigned to closed.
  • resolution set to fixed.

This has been fixed in SVN HEAD and will be part of the 2.2 release

01/08/07 14:46:44 changed by

  • milestone deleted.

Milestone 2.2 deleted

01/08/07 16:07:17 changed by vgster

  • milestone set to 2.2.