Changeset 14218

Show
Ignore:
Timestamp:
06/30/12 16:30:57 (11 months ago)
Author:
p_lindheimer
Message:

remove some of the security auditing code that got checked in error and not used or ready

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • freepbx/branches/2.10/amp_conf/htdocs/admin/libraries/module.functions.php

    r14128 r14218  
    9191  } 
    9292 
    93   $exposures = module_get_security($xmlarray, $base_version); 
    94  
    95   //dbug("done here is exposure analysis", $exposures); 
    96   foreach($exposures as $m => $vinfo) { 
    97     dbug("module $m has these vulnerabilities and version " . $vinfo['minver'] . " is needed you have " . $vinfo['curver'], $vinfo['vul']); 
    98   } 
    99   // module_update_security_notifications($exposures); 
    100  
    10193  if (isset($xmlarray['xml']['module'])) { 
    10294   
     
    112104      foreach ($xmlarray['xml']['module'] as $mod) { 
    113105        $modules[$mod['rawname']] = $mod; 
    114         if (isset($exposures[$mod['rawname']])) { 
    115           $modules[$mod['rawname']]['vulnerabilities'] = $exposures[$mod['rawname']]; 
    116         } 
    117106      } 
    118107      return $modules; 
     
    121110  return null; 
    122111} 
    123  
    124 function module_get_security($xmlarray, $base_version=null) { 
    125  
    126   if ($base_version === null) { 
    127     $version = getversion(); 
    128     // we need to know the freepbx major version we have running (ie: 2.1.2 is 2.1) 
    129     preg_match('/(\d+\.\d+)/',$version,$matches); 
    130     $base_version = $matches[1]; 
    131   } 
    132  
    133   if (!empty($xmlarray['xml']['security'])) { 
    134     $exposures = array(); 
    135     $modinfo = module_getinfo(); 
    136  
    137     //foreach ($xmlarray['xml']['security'] as $vul => $sinfo) { 
    138     foreach ($xmlarray['xml']['security']['issue'] as $sinfo) { 
    139       $vul = $sinfo['id']; 
    140       if (!empty($sinfo['versions']['v' . $base_version])) { 
    141         //dbug("vulnerability info for $base_version: ", $sinfo['versions']['v' . $base_version]); 
    142         //dbug("is vulnerable?:: " . $sinfo['versions']['v' . $base_version]['vulnerable']); 
    143         // TODO: if vulnerable or maybe, and no fixes listed need to post something, mostly around the unknown 
    144         if (strtolower($sinfo['versions']['v' . $base_version]['vulnerable']) == 'yes' && !empty($sinfo['versions']['v' . $base_version]['fixes'])) foreach ($sinfo['versions']['v' . $base_version]['fixes'] as $rmod => $mver) { 
    145           dbug("checking $rmod"); 
    146           $rmod = trim($rmod); 
    147           $mver = trim($mver); 
    148           if (!empty($modinfo[trim($rmod)])) { 
    149             //dbug("Vulnerability: $vul, module: " . $rmod . ", version: " . $mver); 
    150             if (!isset($modinfo[$rmod]['dbversion'])) { 
    151               //dbug("dbversion isn't set for $rmod so Locally Available but NOT installed, report on it"); 
    152             } else { 
    153               if (version_compare_freepbx($modinfo[$rmod]['dbversion'], $mver, 'lt')) { 
    154                 if (!isset($exposures[$rmod])) { 
    155                   //dbug("$rmod not set so setting min ver to $mver"); 
    156                   $exposures[$rmod] = array('vul' => array($vul), 'minver' => $mver, 'curver' => $modinfo[$rmod]['dbversion']); 
    157                 } else { 
    158                   $exposures[$rmod]['vul'][] = $vul; 
    159                   //dbug("$rmod IS set so setting so check $mver against current minver: " . $exposures[$rmod]['minver']); 
    160                   if (version_compare_freepbx($mver, $exposures[$rmod]['minver'], 'gt')) { 
    161                     //dbug("since the new $mver is greater, we are setting $rmod up to it because of $vul"); 
    162                     $exposures[$rmod]['minver'] = $mver; 
    163                   } 
    164                 } 
    165               } else { 
    166                 //dbug($modinfo[$rmod]['dbversion'] . " is at least $mver"); 
    167               } 
    168             } 
    169           } else { 
    170             //dbug("module $rmod not there or"); 
    171           } 
    172         } 
    173       } 
    174     } 
    175     return $exposures; 
    176   } 
    177 } 
    178  
    179112 
    180113/**  Determines if there are updates we don't already know about and posts to notification