Changeset 6604

Show
Ignore:
Timestamp:
09/07/08 21:32:35 (5 years ago)
Author:
p_lindheimer
Message:

re #3147, allows a 0 sec retry as before, rename None to 'No Retry', clarify the tooltip info, and change none to 0 in queues.conf when none is selected so that future versions of Asterisk don't get upset with a bogus value since it expects a number

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/branches/2.5/queues/functions.inc.php

    r6603 r6604  
    7878            case 'autofill':  
    7979              break; 
     80            case 'retry':  
     81              if ($data == 'none') { 
     82                $data = 0; 
     83              } 
     84              // no break, fallthrough to default 
    8085            default: 
    8186              $output .= $keyword."=".$data."\n"; 
     
    95100            case 'ringinuse':  
    96101              break; 
     102            case 'retry':  
     103              if ($data == 'none') { 
     104                $data = 0; 
     105              } 
     106              // no break, fallthrough to default 
    97107            default: 
    98108              $output .= $keyword."=".$data."\n"; 
     
    299309          } 
    300310          $options = 't'; 
    301           if ($q['rtone'] == 1) 
     311          if ($q['rtone'] == 1) { 
    302312            $options .= 'r'; 
    303           if ($q['retry'] == none){ 
    304              $options .= 'n'; 
    305              } 
     313          } 
     314          if ($q['retry'] == 'none'){ 
     315            $options .= 'n'; 
     316          } 
    306317          if (isset($q['music'])) { 
    307318            $ext->add('ext-queues', $exten, '', new ext_setvar('__MOHCLASS', $q['music'])); 
  • modules/branches/2.5/queues/page.queues.php

    r6603 r6604  
    461461 
    462462  <tr> 
    463     <td><a href="#" class="info"><?php echo _("Retry:")?><span><?php echo _("The number of seconds we wait before trying all the phones again. Select none to dissable retying and to go straight to the fail over destination")?></span></a></td> 
     463    <td><a href="#" class="info"><?php echo _("Retry:")?><span><?php echo _("The number of seconds we wait before trying all the phones again. Choosing \"No Retry\" will exit the Queue and go to the fail-over destination as soon as the first attempted agent times-out, additional agents will not be attempted.")?></span></a></td> 
    464464    <td> 
    465465      <select name="retry" tabindex="<?php echo ++$tabindex;?>"> 
    466466      <?php 
    467467        $default = (isset($retry) ? $retry : 5); 
    468         echo '<option value="none" '.($default == "none" ? 'SELECTED' : '').'>'._("None").'</option>'; 
    469         for ($i=1; $i <= 20; $i++) { 
    470           echo '<option value="'.$i.'" '.($i == $default ? 'SELECTED' : '').'>'.queues_timeString($i,true).'</option>'; 
     468        echo '<option value="none" '.($default == "none" ? 'SELECTED' : '').'>'._("No Retry").'</option>'; 
     469        for ($i=0; $i <= 20; $i++) { 
     470          echo '<option value="'.$i.'" '.($i === $default ? 'SELECTED' : '').'>'.queues_timeString($i,true).'</option>'; 
    471471        } 
    472472      ?>