Ticket #1498 (new Feature Requests)

Opened 6 years ago

Last modified 6 years ago

music module: check conversion of uploaded files was successful, make conversion optional

Reported by: hevad57 Assigned to:
Priority: minor Milestone: Undetermined
Component: Music On Hold Version: SVN-HEAD
Keywords: Cc:
Confirmation: Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

If a ".wav" file is uploaded using the MOH module it is given a ".mp3" extension. Also any ".wav" files in the mohmp3 directory are not recognized by the UI.

Change History

12/07/06 03:27:55 changed by p_lindheimer

  • priority changed from major to minor.

12/18/06 16:39:32 changed by vgster

Does it still play after being uploaded and renamed .mp3?

12/21/06 10:23:57 changed by hevad57

Yes, they play OK, but are not visible to freepbx.

12/25/06 07:33:09 changed by vgster

Maybe this is more of a feature request to have freePBX list all the formats of MOH that asterisk can play and not just mp3.

12/27/06 04:57:03 changed by vgster

  • type changed from Bugs to Feature Requests.
  • summary changed from Uploading ".wav" files is incorrect for MOH to Display all Asterisk handled music formats in MOH category list.

Moved to feature requests.

12/27/06 08:59:42 changed by hevad57

I'm not sure on how this project defines a feature request, but to I would of thought deviating from documented behaviour would be a bug. The music upload feature specifically states it can accept mp3 files and it doesn't.

12/27/06 09:04:48 changed by vgster

I thought that the issue was that .wavs in the moh category folder aren't being shown by freePBX? Once the .wav is uploaded is it converted to a .mp3 or is a .wav with a .mp3 extension? I'm more than happy to move this back to bugs.

12/27/06 09:12:24 changed by hevad57

Last time I tried uploading a wav file an mp3 extension was tacked on (music.wav.mp3), but it didn't play, so I guess it wasn't converted, just broken...

12/27/06 09:18:48 changed by vgster

  • type changed from Feature Requests to Bugs.
  • summary changed from Display all Asterisk handled music formats in MOH category list to Uploading ".wav" files is incorrect for MOH.

Ah ok, I might haave got confused by a previous comment you made about them playing. I will move it back.

01/03/07 01:33:26 changed by gregmac

  • summary changed from Uploading ".wav" files is incorrect for MOH to music module: check conversion of uploaded files was successful, make conversion optional.
  • type changed from Bugs to Feature Requests.
  • version changed from 2.2rc1 to SVN-HEAD.
  • milestone changed from 2.2 to 2.3.

r3502 (2.2) lists .wav files (r3501 on 2.3)

wav uploading problem seems to be an issue with lame (the mp3 encoder).

Changing this to a feature request to solidfy lame support:

  • It should check the exit code from lame, and report errors if necessary
  • May be desirable to replace .wav with .mp3, instead of appending (.wav.mp3) - but OTOH, this does show that the file was converted
  • It should give the option of not converting uploaded files

01/08/07 14:46:49 changed by

  • milestone deleted.

Milestone 2.3 deleted

01/08/07 15:15:43 changed by vgster

  • milestone set to 2.3.