Ticket #2269 (closed Bugs: fixed)

Opened 6 years ago

Last modified 5 years ago

restoreastdb.php does not clear astdb before restoring data

Reported by: dpmott Assigned to:
Priority: minor Milestone: 2.4
Component: Backup & Restore Version: 2.4-branch
Keywords: astdb Cc:
Confirmation: Confirmed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Note that this bug is filed because the behavior of astdb differs from the backup/restore functionality that exists for the MySQL database, and no comments are supplied in restoreastdb.php that indicate the desired or expected behavior.

The restoreastdb.php does not clear the astdb database before restoring it. As a result, the following can happen: 1. Create a backup of astdb. 2. Via FreePBX, perform operations that would update astdb. 3. Restore the astdb file. 4. Note that the entries created in #2 still exist.

While I'm on it... the comment on line 27 is wrong; nothing is written to /tmp.

Change History

08/19/07 03:05:20 changed by p_lindheimer

  • version changed from 2.2.3 to 2.3-branch.
  • milestone changed from 3.0 to 2.3.

09/08/07 14:08:52 changed by p_lindheimer

  • confirmation changed from Unreviewed to Confirmed.
  • version changed from 2.3-branch to SVN-HEAD.

this is a tough one and I think it needs to be addressed when backup is written properly.

The issue is that there is a lot of state information that you may not want changed but in the current implementation it may or may not be changed.

Whether we do this or leave it as is both have issues which need to be addressed and trying to patch up the current backup module is not productive until we overhaul it.

11/13/07 15:14:10 changed by p_lindheimer

  • milestone deleted.

01/27/08 12:26:59 changed by p_lindheimer

  • status changed from new to closed.
  • version changed from SVN-HEAD to 2.4-branch.
  • resolution set to fixed.
  • milestone set to 2.4.

r5619 there may be other trees that need to be deleted before restoring. Feel free to open up a new bug with suggestions.