Ticket #2579 (closed Feature Requests: fixed)

Opened 5 years ago

Last modified 5 years ago

Queue configuration should allow setting "joinempty" and "leavewhenempty" to "strict"

Reported by: rjh Assigned to:
Priority: major Milestone: Undetermined
Component: Queues Version: 2.3.1
Keywords: Cc:
Confirmation: Confirmed Distro:
Backend Engine: Asterisk 1.4.x Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Asterisk 1.4 doesn't really function properly with these settings if they are set to yes and no respectively - the best functionality is when they are both set to "strict"

However the "queue" module only allows yes and no to be set. The inability to configure this is somewhat of a major problem for us since it ends up with complaint emails from stupid people who end up in a queue at 3am in the morning and hold on for forty minutes waiting for someone to answer their call.

Change History

12/28/07 01:29:13 changed by rjh

I've patched my own Queue module as follows, and it seems to work just fine. Hopefully I'm not missing anything. 

Index: amp_conf/htdocs/admin/modules/queues/page.queues.php
===================================================================
--- amp_conf/htdocs/admin/modules/queues/page.queues.php        (revision 5555)
+++ amp_conf/htdocs/admin/modules/queues/page.queues.php        (working copy)
@@ -371,7 +371,7 @@
                        <select name="joinempty"/>
                        <?php
                                $default = (isset($joinempty) ? $joinempty : 'yes');
-                               $items = array('yes'=>_("Yes"),'no'=>_("No"));
+                               $items = array('yes'=>_("Yes"),'strict'=>_("Strict"),'no'=>_("No"));
                                foreach ($items as $item=>$val) {
                                        echo '<option value="'.$item.'" '. ($default == $item ? 'SELECTED' : '').'>'.$val;
                                }
@@ -386,7 +386,7 @@
                        <select name="leavewhenempty"/>
                        <?php
                                $default = (isset($leavewhenempty) ? $leavewhenempty : 'no');
-                               $items = array('yes'=>_("Yes"),'no'=>_("No"));
+                               $items = array('yes'=>_("Yes"),'strict'=>_("Strict"),'no'=>_("No"));
                                foreach ($items as $item=>$val) {
                                        echo '<option value="'.$item.'" '. ($default == $item ? 'SELECTED' : '').'>'.$val;
                                }

12/29/07 17:40:48 changed by pnlarsson

  • status changed from new to closed.
  • confirmation changed from Unreviewed to Confirmed.
  • resolution set to fixed.

R5556 - committed to 2.4 - thanks!

12/29/07 17:43:55 changed by pnlarsson

r5556 is the changeset