Ticket #3423 (closed Patches: fixed)

Opened 1 year ago

Last modified 7 months ago

enumlookup.agi does not use enum.conf, wrong delimiter returned in DIALARR

Reported by: matka Assigned to: p_lindheimer
Priority: minor Milestone: 2.6
Component: Core - Trunks/Routing Version: 2.5-branch
Keywords: enum lookup Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

I've been doing some emum testing and noticed couple of bugs.

Enum orgs that are searched are hard coded in the array in the agi, and only 1 enum164.org is enabled. Yes, I read the previous bug regarding this, I think it would be more flexible to parse enum.conf for search option.

The return string in DIALARR has ENUM lookup results separated by "|", macro-dialout-enum is expecting "%". As a result, CUT functions does not work and there is no loop back to the enum dial in case of a first dial failure.

I'm attaching a patch file.

George

Attachments

mypatch.diff (3.0 kB) - added by matka on 11/29/08 09:49:53.
proposed changes
core-functions.inc.php-patch-enum.diff (0.9 kB) - added by drmessano on 05/10/09 22:35:31.

Change History

11/29/08 09:49:53 changed by matka

  • attachment mypatch.diff added.

proposed changes

04/22/09 01:55:01 changed by ryppn

This patch is required for enum to function under asterisk 1.6 , however the [macro-dialout-enum] also requires the comma removed from the Dial command on step 13, ie exten => s,n,Dial(${TRYDIAL})

Once these changes are effected, enum functions once again under asterisk 1.6 without the garbage on the end of the dialstring.

Regards,

RypPn?

05/10/09 22:35:31 changed by drmessano

  • attachment core-functions.inc.php-patch-enum.diff added.

05/10/09 22:42:02 changed by drmessano

Added patch for the change noted by RypPn?. Can confirm this works now on 1.6.

Also think we need to implement the AGI changes to get a complete, working ENUM setup. The hardcoded AGI is limiting, and the one listed is problematic. This should not be up to FreePBX to keep up with, as the enum.conf would work fine to track these changes.

05/13/09 15:49:20 changed by xrobau

  • status changed from new to closed.
  • resolution set to fixed.

Added supplied fixes, with some massaging, to trunk (to be 2.6) - thanks!

05/13/09 15:51:29 changed by xrobau

Forgot to mention, changes are in r7721

08/30/09 07:58:23 changed by p_lindheimer

(In [8252]) fixes #3844 enum stopped working, reverted previous update re #3423 but left authors new licensing

08/30/09 12:32:13 changed by p_lindheimer

(In [8254]) fixes #3846 and relevant re #3833 and re #3423