Ticket #3949 (closed Bugs: fixed)

Opened 4 years ago

Last modified 3 years ago

Speed Dial Functions ignores the rules of contexts

Reported by: Maikel Assigned to:
Priority: major Milestone: 2.7
Component: Speed Dial Functions Version: 2.6-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

The numbers stored in speed dial functions completely ignore the rules of contexts.

The file attached is the new version with bug fixed.

Attachments

speeddial-2.5.1.tar.gz (17.0 kB) - added by Maikel on 11/10/09 20:35:27.
speeddial.diff (1.3 kB) - added by mickecarlsson on 11/11/09 00:53:10.
diff file for speeddial

Change History

11/10/09 20:35:27 changed by Maikel

  • attachment speeddial-2.5.1.tar.gz added.

11/11/09 00:53:10 changed by mickecarlsson

  • attachment speeddial.diff added.

diff file for speeddial

11/11/09 13:40:03 changed by mickecarlsson

Why do you want change the @from-internal? Speeddial is only called when using the feature code. It is never called outside that scope.

Could you please explain why you want it to follow the ${CONTEXT}

11/11/09 13:50:11 changed by Maikel

Because if you use custom contexts, the speed dial ignore the rules of context. When we use the variable (CONTEXT), we ensure that the number stored in speed dial is reviewed again by the rules of the context in question.

01/28/10 14:53:54 changed by p_lindheimer

I understand why you want to change it to ${CONTEXT} and would be inclined to agree this would be a good change. However, why are you changing it from Dial to Goto? (I'm not suggesting that is wrong as there are other places that used to be Dial() and were changed to goto, I would just like to know why this was determined and any testing, so as not to break something subtle by blindly changing this since there are differences that occur (like non-inheritable channel variables are no longer cleared, ...)

02/09/10 20:22:12 changed by p_lindheimer

since there is no feedback, I'm going to play it conservative and leave it as a dial (even though I am inclined to change it to goto). Doing such minimizes any subtle differences that could crop up.

02/09/10 20:23:15 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [8799]) fixes #3949 use CONTEXT instead of form-internal to deal with custom context issues