Ticket #3982 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

Backup 2.6.0.4 redefines dbug function

Reported by: GameGamer43 Assigned to:
Priority: major Milestone: 2.6
Component: Backup & Restore Version: 2.6-branch
Keywords: Cc: mbrevda
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

The new backup module which uses the PHP port of the old perl script breaks when attempting to do a backup. This is caused by trying to redefine the dbug function in functions.inc.php. As a result we should be deleting that function from the backup modules functions.inc.php. Another issue is that we try to do #!/usr/bin/env php in the ampbackup.php file. As this is not a perl script, we do not need to do this as doing so makes it show up in the GUI.

Change History

12/29/09 00:00:49 changed by mbrevda

Bryan, While we can remove the debug function , iirc the error only showed when there was another, unrelated issue. As far as #!/usr/bin/env php - that is necessary in order to run the script from the command line, witch is how its run most of the time.

12/29/09 00:01:52 changed by mbrevda

  • summary changed from 2.6.0.4 Backup Module is Broken to Backup 2.6.0.4 redefines dbug function.

12/29/09 01:23:42 changed by GameGamer43

Actually, you shouldn't need to use #!/usr/bin/env php, as if running from the command line you should just be able to do php ampbackup.php. Maybe I'm missing something or just not grasping something here.

As for the dbug function, I'm not entirely sure why we are redefining it in the first place. I mean when I tried the new module, it failed completely due to the redefinition of the dbug function, so not sure of the unrelated issue here.

12/29/09 01:30:23 changed by GameGamer43

Actually, with regards to #!/usr/bin/env php, I got that it's another way to do it but we have to keep in mind that at the moment it's also being echo'd out to the screen, which is less than ideal.

12/29/09 09:12:01 changed by mbrevda

  • status changed from new to closed.
  • resolution set to fixed.

(In [8455]) closes #3982

12/29/09 09:12:40 changed by mbrevda

GameGamer?43 - issues should be resolved. Kindly test&confirm so that this can be published.

(follow-up: ↓ 8 ) 12/29/09 14:32:30 changed by mickecarlsson

mbrevda, could you just check line 244, $debug=true; is that what you want per default?

(in reply to: ↑ 7 ) 12/29/09 15:53:54 changed by mbrevda

Replying to mickecarlsson:

mbrevda, could you just check line 244, $debug=true; is that what you want per default?

It really doesn't matter as the function is never called.

01/05/10 18:58:01 changed by p_lindheimer

(In [8563]) revert r8465, r8455 left in 2.7 for testing re #3996 and re #3982

01/05/10 19:01:59 changed by p_lindheimer

(In [8564]) Blocked revisions 8562-8563 via svnmerge

........

r8562 | p_lindheimer | 2010-01-05 15:54:43 -0800 (Tue, 05 Jan 2010) | 1 line

revert r8461 left in 2.7 where it can be tested, re #3594

........

r8563 | p_lindheimer | 2010-01-05 15:58:00 -0800 (Tue, 05 Jan 2010) | 1 line

revert r8465, r8455 left in 2.7 for testing re #3996 and re #3982

........