Ticket #4172 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

drawselects does not localize

Reported by: mickecarlsson Assigned to: mbrevda
Priority: major Milestone: 2.8
Component: FreePBX Framework Version: SVN-HEAD
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

When using drawselects to display the new nice selections list in 2.8, the text displayed in the list does not localize.

Ticket created as a reminder to solve this before 2.8 is released. It breaks all localization for all langauges.

Change History

03/27/10 09:37:46 changed by mickecarlsson

(In [9404]) Re #4172 fixed localization in drawselects. To do: fix the localization for Hangup Call. Aloso enclosed text string for localization

03/27/10 09:48:58 changed by mickecarlsson

(In [9405]) Re #4172 fixed spelling error

03/27/10 10:33:12 changed by p_lindheimer

  • owner set to mbrevda.

Can you work with Moshe on this, I'll be on the beach :)

but try this, I think it may be the issue, just make sure if localization is fixed that it still actually works:) 

Index: functions.inc.php
===================================================================
--- functions.inc.php   (revision 9371)
+++ functions.inc.php   (working copy)
@@ -2048,7 +2048,7 @@
                /* end i18n */
                $selected=($mod==$destmod)?' SELECTED ':' ';
                $style=' style="'.(($mod=='Error')?'background-color:red;':'background-color:white;').'"';
-               $html.='<option value="'.str_replace(' ','_',$mod).'"'.$selected.$style.'>'.$mod.'</option>';
+               $html.='<option value="'.str_replace(' ','_',$mod).'"'.$selected.$style.'>'.$label_text.'</option>';
        }
        $html.='</select> ';

04/07/10 08:40:55 changed by mickecarlsson

(In [9451]) Re #4172 localize child objects in new drawselect. This is my (uggly?!) way to it. I won't close the ticket for now, but I am satisfied with it, and it works, up for discussion

04/07/10 08:47:57 changed by mickecarlsson

(In [9452]) Re #4172 get rid of undefined index in apache error log

04/07/10 13:19:09 changed by mickecarlsson

(In [9461]) Re #4172 finally? fixed the localization for child menus

04/11/10 03:19:34 changed by mbrevda

mickecarlsson: can this be closed?

04/11/10 04:16:45 changed by mickecarlsson

  • status changed from new to closed.
  • resolution set to fixed.

Yes I think so, I have not seen any side affects of it so I'll close it.