Ticket #5000 (closed Bugs: fixed)

Opened 2 years ago

Last modified 2 years ago

add support for buttonsets for radio buttons

Reported by: mbrevda Assigned to: mbrevda
Priority: minor Milestone: 2.9
Component: FreePBX Framework Version: 2.9-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Attachments

button-wrong.PNG (4.1 kB) - added by mickecarlsson on 03/24/11 01:46:55.
Button layout with text wrapped
button-ok.PNG (3.6 kB) - added by mickecarlsson on 03/24/11 01:47:30.
Button with text as it should be

Change History

03/22/11 12:16:31 changed by mbrevda

(In [11892]) re #5000

03/22/11 12:20:37 changed by mbrevda

(In [11893]) re #5000

03/22/11 12:39:41 changed by mbrevda

(In [11894]) re #5000

03/22/11 13:14:29 changed by mbrevda

  • status changed from new to closed.
  • resolution set to fixed.

(In [11895]) closes #5000, unless I messed up in aplying the patch

03/23/11 01:51:40 changed by mickecarlsson

  • status changed from closed to reopened.
  • resolution deleted.

Well, that messes up sipsettings, look at section Videosupport, those buttons are not aligned as they used to be, they needs to be more spaced apart.

03/23/11 13:50:56 changed by p_lindheimer

  • owner set to mbrevda.
  • status changed from reopened to new.

03/23/11 13:55:29 changed by p_lindheimer

mick,

not sure what you are referring to wrt to videosupport specifically. I know there were other sets of radio buttons that were aligned a little nicer before and are a bit less now (and there may be some css to help fix it). The issue before was the formatting was all done with tables and td's which is less then ideal, vs. using CSS (the 'proper' way) so as to allow improved abilities to style/skin things. The question is, can the old layouts of rows of radio buttons be improved at all with some CSS?

but again - was there something I missed wrt to the videosupport specifically?

03/24/11 01:46:55 changed by mickecarlsson

  • attachment button-wrong.PNG added.

Button layout with text wrapped

03/24/11 01:47:30 changed by mickecarlsson

  • attachment button-ok.PNG added.

Button with text as it should be

03/24/11 01:56:45 changed by mickecarlsson

Please look at the two images, the first one are the text fields wrapped, the second one they are not (this is the section for Jitter Buffer).

Disabled have 8 characters, other languages has:

Swedish: Avaktiverad have 11 characters.

Spanish; Deshabilitado have 13 characters

Italian: Disattivato have 11 characters

Portuguese: Desabilitado have 12 character

So, make plenty of room when defining the space for the buttons :-)

03/24/11 13:31:11 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

r11930 I believe these are closed now, the original changes had those thus my confusion when I looked at it after this was filed and didn't see any big problem (since it was fixed on my system :)