Ticket #5168 (closed Bugs: fixed)

Opened 2 years ago

Last modified 1 year ago

When saving settings in Voicemail Admin, undefined are not filtered out

Reported by: mickecarlsson Assigned to:
Priority: minor Milestone: 2.10
Component: Voicemail Version: 2.9-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Go to Voicemail Admin, in System View Links click on Settings, when saving this page, all settings that are marked Undefined are saved in voicmeail.conf as undefined: 

envelope=undefined
forcegreetings=undefined
forcename=undefined
maxmsg=200
moveheard=yes
pollmailboxes=yes
saycid=no
sayduration=no
searchcontexts=no
sendvoicemail=no
tempgreetwarn=undefined
usedirectory=undefined
charset=utf-8

Change History

02/21/12 19:59:04 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [13545]) fixes #5135 make polling default on and fixes #5168 get rid of undefined for booleans and create default options for all settings, for now just booleans and pollfreq are set but feel free to suggest other defaults as well as changes to what was chosen.

02/21/12 21:31:44 changed by TimMillerDyck

As input for possible defaults:

1. format: wav|wav49

Users find the lower-quality wav49 recordings harder to understand

2. maxsecs: 300

180 seconds is often too short

3. maxsilence: 10

had problems with callers looking up a number to speak into a voicemail and getting hung up on with the default 5 second timeout

4. volgain: 6

needs sox to be installed, but it is on FreePBX Distro -- users found e-mailed voice mails too quiet without this

5. maxlogins: 5

some protection against voicemail password guessing attacks

6. backupdeleted: 10

some protection against accidental voicemail deletion

7. maxmessage

deprecated in favor of maxsecs -- hide or remove maxmessage?

Note: there are some places where the tooltip for the item says the default is different than what is set in the patch at http://www.freepbx.org/trac/changeset/13545 . These are the ones I noticed:

  • moveheard
  • forcename
  • nextaftercmd
  • operator

-Tim Miller Dyck