Ticket #5176 (closed Bugs: fixed)

Opened 2 years ago

Last modified 2 years ago

TIme Conditions Feature Code Initialized disabled very confusing

Reported by: p_lindheimer Assigned to:
Priority: minor Milestone: 2.10
Component: Time Conditions Version: 2.9-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

This is probably debatable, bug or feature request. If someone wants to change it feel free but either way it needs fixing on the 2.9 branch. The issue is when a Time Condition is first created, we default it to disabled since there is system overhead if it is enabled and we don't want that unless people are using it.

This adds lots of complications because you have to bounce around to the Feature Code panel just to find out what the new code is and enable it, since if not enabled, you can't even use the tool tips to see it. So we need to add the ability to set whether it is enabled or not upon creation as well as view and change that from the GUI.

Change History

05/24/11 23:12:31 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [12190]) fixes #5175 and fixes #5176 initialize state of feature code and allow enable/disable from within the gui, some sanity testing would be helpful before I publish this widely

05/25/11 13:52:02 changed by p_lindheimer

(In [12192]) display default code outside of tooltip re #5175 and re #5176

08/29/11 18:34:11 changed by p_lindheimer

(In [12460]) Merged revisions 12185,12190,12192,12194,12214-12215,12218,12256,12294,12305,12383-12384,12424,12434,12455 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.9

................

r12185 | mickecarlsson | 2011-05-21 15:00:11 -0700 (Sat, 21 May 2011) | 1 line

Closes #5161 fixes bad validation code

................

r12190 | p_lindheimer | 2011-05-24 20:12:30 -0700 (Tue, 24 May 2011) | 1 line

fixes #5175 and fixes #5176 initialize state of feature code and allow enable/disable from within the gui, some sanity testing would be helpful before I publish this widely

................

r12192 | p_lindheimer | 2011-05-25 10:52:02 -0700 (Wed, 25 May 2011) | 1 line

display default code outside of tooltip re #5175 and re #5176

................

r12194 | GameGamer?43 | 2011-05-25 21:53:13 -0700 (Wed, 25 May 2011) | 1 line

closes #5182 - misspelling in tooltip

................

r12214 | mbrevda | 2011-06-06 07:42:06 -0700 (Mon, 06 Jun 2011) | 1 line

merge to 2.9 for #5127, #5054, #5049, #5140

................

r12215 | mbrevda | 2011-06-06 07:56:21 -0700 (Mon, 06 Jun 2011) | 1 line

merge to 2.9 re #5127, #5054, #5049, #5140, #5142

................

r12218 | mbrevda | 2011-06-06 08:16:19 -0700 (Mon, 06 Jun 2011) | 1 line

unervert the unrevert re #5127, #5054, #5049, #5140, #5142

................

r12256 | mbrevda | 2011-06-13 11:33:13 -0700 (Mon, 13 Jun 2011) | 1 line

revert 12255

................

r12294 | p_lindheimer | 2011-07-07 12:29:11 -0700 (Thu, 07 Jul 2011) | 1 line

fixes #5159 don't set to empty quotes, thanks spermega and Lantizia

................

r12305 | mbrevda | 2011-07-17 04:32:10 -0700 (Sun, 17 Jul 2011) | 1 line

re #5262 should resolve

................

r12383 | p_lindheimer | 2011-08-09 12:10:52 -0700 (Tue, 09 Aug 2011) | 9 lines

Merged revisions 12382 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.8

........

r12382 | p_lindheimer | 2011-08-09 12:07:06 -0700 (Tue, 09 Aug 2011) | 1 line

fixes #5312 don't include in from-internal

........

................

r12384 | p_lindheimer | 2011-08-09 12:17:04 -0700 (Tue, 09 Aug 2011) | 1 line

fixes #5313 delete the record

................

r12424 | mbrevda | 2011-08-19 06:17:52 -0700 (Fri, 19 Aug 2011) | 1 line

closes #5320, call eval on mixmon_dir

................

r12434 | mickecarlsson | 2011-08-21 21:45:22 -0700 (Sun, 21 Aug 2011) | 1 line

Close #5187, add check for offline endpoints in macro-dial-one

................

r12455 | p_lindheimer | 2011-08-29 14:28:53 -0700 (Mon, 29 Aug 2011) | 9 lines

Merged revisions 11567-11569,11572,11754,11896-11897,11899,12018-12019,12233-12234,12382,12385,12387,12452,12454 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.8

........

r12387 | p_lindheimer | 2011-08-09 15:12:07 -0700 (Tue, 09 Aug 2011) | 1 line

should fix custom trunk destination re #5314 pls test and provide feedback then will put in and merge up

........

................

09/20/11 19:53:24 changed by p_lindheimer

(In [12551]) Merged revisions 12169,12184-12185,12190,12192,12194-12197,12206,12214-12219,12232,12255-12256,12294,12305-12306,12312-12313,12364-12366,12368,12370-12371,12383-12384,12386,12389,12424-12425,12427-12428,12430-12435,12455,12487-12488,12531,12534 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.9

................

r12185 | mickecarlsson | 2011-05-21 15:00:11 -0700 (Sat, 21 May 2011) | 1 line

Closes #5161 fixes bad validation code

................

r12190 | p_lindheimer | 2011-05-24 20:12:30 -0700 (Tue, 24 May 2011) | 1 line

fixes #5175 and fixes #5176 initialize state of feature code and allow enable/disable from within the gui, some sanity testing would be helpful before I publish this widely

................

r12192 | p_lindheimer | 2011-05-25 10:52:02 -0700 (Wed, 25 May 2011) | 1 line

display default code outside of tooltip re #5175 and re #5176

................

r12194 | GameGamer?43 | 2011-05-25 21:53:13 -0700 (Wed, 25 May 2011) | 1 line

closes #5182 - misspelling in tooltip

................

r12214 | mbrevda | 2011-06-06 07:42:06 -0700 (Mon, 06 Jun 2011) | 1 line

merge to 2.9 for #5127, #5054, #5049, #5140

................

r12215 | mbrevda | 2011-06-06 07:56:21 -0700 (Mon, 06 Jun 2011) | 1 line

merge to 2.9 re #5127, #5054, #5049, #5140, #5142

................

r12216 | mbrevda | 2011-06-06 07:57:08 -0700 (Mon, 06 Jun 2011) | 1 line

version bump re #5127, #5054, #5049, #5140, #5142

................

r12218 | mbrevda | 2011-06-06 08:16:19 -0700 (Mon, 06 Jun 2011) | 1 line

unervert the unrevert re #5127, #5054, #5049, #5140, #5142

................

r12256 | mbrevda | 2011-06-13 11:33:13 -0700 (Mon, 13 Jun 2011) | 1 line

revert 12255

................

r12294 | p_lindheimer | 2011-07-07 12:29:11 -0700 (Thu, 07 Jul 2011) | 1 line

fixes #5159 don't set to empty quotes, thanks spermega and Lantizia

................

r12305 | mbrevda | 2011-07-17 04:32:10 -0700 (Sun, 17 Jul 2011) | 1 line

re #5262 should resolve

................

r12364 | mickecarlsson | 2011-08-07 14:18:44 -0700 (Sun, 07 Aug 2011) | 1 line

Closes #5289, fixed restore issue for astdb

................

r12383 | p_lindheimer | 2011-08-09 12:10:52 -0700 (Tue, 09 Aug 2011) | 9 lines

Merged revisions 12382 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.8

........

r12382 | p_lindheimer | 2011-08-09 12:07:06 -0700 (Tue, 09 Aug 2011) | 1 line

fixes #5312 don't include in from-internal

........

................

r12384 | p_lindheimer | 2011-08-09 12:17:04 -0700 (Tue, 09 Aug 2011) | 1 line

fixes #5313 delete the record

................

r12424 | mbrevda | 2011-08-19 06:17:52 -0700 (Fri, 19 Aug 2011) | 1 line

closes #5320, call eval on mixmon_dir

................

r12434 | mickecarlsson | 2011-08-21 21:45:22 -0700 (Sun, 21 Aug 2011) | 1 line

Close #5187, add check for offline endpoints in macro-dial-one

................

r12455 | p_lindheimer | 2011-08-29 14:28:53 -0700 (Mon, 29 Aug 2011) | 9 lines

Merged revisions 11567-11569,11572,11754,11896-11897,11899,12018-12019,12233-12234,12382,12385,12387,12452,12454 via svnmerge from http://www.freepbx.org/v2/svn/modules/branches/2.8

........

r12387 | p_lindheimer | 2011-08-09 15:12:07 -0700 (Tue, 09 Aug 2011) | 1 line

should fix custom trunk destination re #5314 pls test and provide feedback then will put in and merge up

........

................

r12487 | mbrevda | 2011-09-07 04:36:07 -0700 (Wed, 07 Sep 2011) | 1 line

re #5355 - merge to 2.9

................

r12534 | mbrevda | 2011-09-18 05:14:00 -0700 (Sun, 18 Sep 2011) | 1 line

re #5302 - use invalid recording on loop

................